Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide capability to use an existing Kubernetes secret for the gateway.auth.key #84

Closed
LDL-GH opened this issue Apr 29, 2022 · 5 comments · Fixed by #99
Closed

Provide capability to use an existing Kubernetes secret for the gateway.auth.key #84

LDL-GH opened this issue Apr 29, 2022 · 5 comments · Fixed by #99
Assignees
Labels
Milestone

Comments

@LDL-GH
Copy link
Contributor

LDL-GH commented Apr 29, 2022

Proposal

Right now we need to input the gateway.auth.key as a value in the helm chart. And the secret is created by the helm chart
However it would be nice to also be able to reference an existing secret.

Use-Case

This way the secret value can be managed separately from the helm chart.
Also the key is not visible, only the secret name.

Anything else?

No response

@tomkerkhove tomkerkhove changed the title [Helm] Make it possible to use an existing secret for the gateway.auth.key Provide capability to use an existing Kubernetes secret for the gateway.auth.key Apr 29, 2022
@tomkerkhove tomkerkhove added this to the v1.1.0 milestone Apr 29, 2022
@tomkerkhove tomkerkhove self-assigned this Apr 29, 2022
@tomkerkhove tomkerkhove assigned LDL-GH and unassigned tomkerkhove May 13, 2022
@tomkerkhove
Copy link
Member

@LDL-GH I'm going to cut a release, are you planning on contributing this later on or should I wait?

@LDL-GH
Copy link
Contributor Author

LDL-GH commented May 13, 2022

@tomkerkhove Looking at it right now, I'll let you know where I stand in an hour

@tomkerkhove
Copy link
Member

Sounds good, thank you!

@LDL-GH
Copy link
Contributor Author

LDL-GH commented May 13, 2022

@tomkerkhove PR is ready for review.
Just in time I hope?

@tomkerkhove
Copy link
Member

Certainly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants