Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit generated type for binary bytes #2089

Open
qiaozha opened this issue Oct 27, 2023 · 0 comments
Open

Revisit generated type for binary bytes #2089

qiaozha opened this issue Oct 27, 2023 · 0 comments
Assignees
Labels
HRLC Mgmt This issue is related to a management-plane library. P1 priority 1 RLC

Comments

@qiaozha
Copy link
Member

qiaozha commented Oct 27, 2023

If we get a binary bytes,

in RLC layer,
if it's in input model, we should generate it as string | Uint8Array | ReadableStream<Uint8Array> | NodeJS.ReadableStream,
if it's in output model, we will generate it as Uint8Array

in Modular layer,
current implemtation is to treat it as Uint8Array regardless input or output.

This could be problematic if there's a large file to upload in the Modular layer. And I am a little concerned if Uint8Array is appropriate if there's a large file to download in RLC ?

we need to revisit how to handle binary bytes in both RLC and Modular in the context of input and output.

Also, do we need to revisit the decision on whether splitting models as input and output in the modular layer ? Given there's a similar discussion about unknown being handled differently in the RLC layer between input and output and we are struggling about how to express unknown in the Modular layer. see details from #2078

/cc @xirzec @joheredi

@qiaozha qiaozha changed the title Revisit generated type for binary bytes in Modular Revisit generated type for binary bytes Oct 27, 2023
@MaryGao MaryGao added the Mgmt This issue is related to a management-plane library. label Oct 27, 2023
@qiaozha qiaozha assigned MaryGao and qiaozha and unassigned MaryGao Nov 1, 2023
@qiaozha qiaozha added the P1 priority 1 label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HRLC Mgmt This issue is related to a management-plane library. P1 priority 1 RLC
Projects
None yet
Development

No branches or pull requests

2 participants