Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change enum definition to latest grammer #4945

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Apr 10, 2024

Fix #4943

@pshao25
Copy link
Member Author

pshao25 commented Apr 11, 2024

Please hold on this until architects have a decision.

InvalidCountryHint,
union InnerErrorCode {
string,
"InvalidRequest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"InvalidRequest",
InvalidRequest: "InvalidRequest",

the correct way should be with a name otherwise the variants have no names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openapi-to-typespec] Use union instead of enum
2 participants