Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #135

Closed
SeanFeldman opened this issue Feb 13, 2019 · 3 comments
Closed

Release 2.4.0 #135

SeanFeldman opened this issue Feb 13, 2019 · 3 comments

Comments

@SeanFeldman
Copy link

Release notes say "breaking changes".
image

Shouldn't this be then a new major, 3.0?

@xinchen10
Copy link
Member

For various reasons we do not strictly follow semantic versioning right now. The changes require no app code updates but a recompilation. Sometimes we increment MINOR if the changes are on types that are meant for internal implementation only. I hope after the next major release we can follow semantic versioning.

@SeanFeldman
Copy link
Author

For various reasons we do not strictly follow semantic versioning right now.

🙀

Sometimes we increment MINOR if the changes are on types that are meant for internal implementation only

That definitely should be a minor 🙂

I hope after the next major release we can follow semantic versioning.

👍 it would be great to see that happening. It's pretty much a norm these days and those 3 numbers have a substantial meaning. Thanks.

PS: will 2.4.0 show up on NuGet at some point?

@mikanyg
Copy link

mikanyg commented Feb 25, 2019

Has this version been published to nuget.org and then de-listed again? I did some package upgrades last week and version 2.4.0 ended up on my machine causing issues with 3rd party framework. You can see the referenced issue causing problems.

@xinchen10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants