Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image doesn't remove apk virtual package .build-deps #23286

Closed
tspearconquest opened this issue Jul 20, 2022 · 2 comments
Closed

Docker image doesn't remove apk virtual package .build-deps #23286

tspearconquest opened this issue Jul 20, 2022 · 2 comments
Assignees
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request Installation
Milestone

Comments

@tspearconquest
Copy link
Contributor

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command

N/A

Describe the bug

Line 38 of the main azure-cli Dockerfile:
https://github.com/Azure/azure-cli/blob/dev/Dockerfile#L38

This line installs a set of packages as a virtual package called .build-deps but nowhere later on in Dockerfile is this virtual package removed.

To Reproduce

Read the Dockerfile in the dev or main branch of this repo

Expected behavior

These tools installed are intended only for building the azure-cli docker image. Generally speaking these packages are not used during the container runtime and are extra data that doesn't need to be in the image. There should be a corresponding apk --no-cache del --no-network .build-deps near the end of the Dockerfile in order to remove these packages.

Removing these packages will reduce the image size.

Environment summary

N/A

Additional context

@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. Auto-Assign Auto assign by bot Installation labels Jul 20, 2022
@ghost ghost assigned jiasli Jul 20, 2022
@ghost ghost added this to the Backlog milestone Jul 20, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 20, 2022

@jiasli for awareness

@yonzhan yonzhan added feature-request Azure CLI Team The command of the issue is owned by Azure CLI team labels Aug 14, 2022
@bebound
Copy link
Contributor

bebound commented Nov 8, 2023

Close as #27567 is merged.

@bebound bebound closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request Installation
Projects
None yet
Development

No branches or pull requests

4 participants