Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceManager] Improve lock level validation #2771

Closed
tjprescott opened this issue Apr 5, 2017 · 3 comments
Closed

[ResourceManager] Improve lock level validation #2771

tjprescott opened this issue Apr 5, 2017 · 3 comments
Assignees
Labels
ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group Resource Manager
Milestone

Comments

@tjprescott
Copy link
Member

PR #2768 added validation to the lock commands to resolve the command target to either the subscription/resource group/resource level. This validation can be improved using a strategy like that use for VM create to resolve storage profile.

@tjprescott tjprescott added this to the Build Milestone milestone Apr 5, 2017
@tjprescott tjprescott self-assigned this Apr 5, 2017
@brendandburns
Copy link
Member

@tjprescott can you give a pointer to that validation?

@tjprescott
Copy link
Member Author

@brendandburns an example starts here for the type of network balancer to use on a VMSS:
https://github.com/Azure/azure-cli/blob/master/src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_validators.py#L782

Essentially you resolve the "type" using some coarse logic and then you specify the required and forbidden parameters for each case and, based on the type, validate those. The benefit is that you'll get a list of ALL your errors rather than only getting one of potentially many errors with each run.

@brendandburns
Copy link
Member

Closing this since #3106 is merged.

@mozehgir mozehgir added the ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group Resource Manager
Projects
None yet
Development

No branches or pull requests

4 participants