-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resource parsing and api version lookup. #2781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you get "PEP8"ed. 😁 This change looks great to me. I would recommend @johanste take a look.
pep8 issues fixed, please take another look. |
Looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
==========================================
- Coverage 62.89% 62.89% -0.01%
==========================================
Files 480 480
Lines 25994 25997 +3
Branches 3942 3943 +1
==========================================
+ Hits 16350 16351 +1
- Misses 8617 8622 +5
+ Partials 1027 1024 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brendandburns!!
Also add some tests.
Fixes #2695