Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource parsing and api version lookup. #2781

Merged
merged 2 commits into from
Apr 7, 2017

Conversation

brendandburns
Copy link
Member

Also add some tests.

Fixes #2695

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you get "PEP8"ed. 😁 This change looks great to me. I would recommend @johanste take a look.

@brendandburns
Copy link
Member Author

pep8 issues fixed, please take another look.

@johanste
Copy link
Member

johanste commented Apr 6, 2017

Looks good to me.

@codecov-io
Copy link

Codecov Report

Merging #2781 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2781      +/-   ##
==========================================
- Coverage   62.89%   62.89%   -0.01%     
==========================================
  Files         480      480              
  Lines       25994    25997       +3     
  Branches     3942     3943       +1     
==========================================
+ Hits        16350    16351       +1     
- Misses       8617     8622       +5     
+ Partials     1027     1024       -3
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/commands/arm.py 89.21% <ø> (ø) ⬆️
...ource/azure/cli/command_modules/resource/custom.py 50.82% <60%> (-0.11%) ⬇️
...dback/azure/cli/command_modules/feedback/custom.py 34.69% <0%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/util.py 68.99% <0%> (ø) ⬆️
...-cli-role/azure/cli/command_modules/role/custom.py 19.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf2df4...839f0c4. Read the comment docs.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brendandburns!!

@tjprescott tjprescott merged commit a77cd78 into Azure:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants