Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'zip' command #27842

Open
konstantinmalich opened this issue Nov 14, 2023 · 10 comments
Open

Missing 'zip' command #27842

konstantinmalich opened this issue Nov 14, 2023 · 10 comments
Assignees
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@konstantinmalich
Copy link

Describe the bug

Having the following error in my gitlab pipeline starting from today.
/bin/bash: line 272: zip: command not found

I suspect the reason is moving out 'zip' package.

Related command

  script:
  - zip -r ${ARTIFACTS_ZIP_RELATIVE} .

Errors

/bin/bash: line 272: zip: command not found

Issue script & Debug output

/bin/bash: line 272: zip: command not found

Expected behavior

Running without errors.

Environment Summary

the latest (2.54.0) docker image
Using docker image sha256:26e402082d83c7a0adfea18dc4b402f6c72c5dfcd607972190cbf7d69d9527a1 for mcr.microsoft.com/azure-cli with digest mcr.microsoft.com/azure-cli@sha256:81459f7ca76c41ad8582bca1ab7bfb332ad9f5be6382bf89b99911dd2616ab08

Additional context

No response

@konstantinmalich konstantinmalich added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Nov 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 14, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 14, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Azure CLI Team The command of the issue is owned by Azure CLI team and removed bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Nov 14, 2023
@yonzhan yonzhan added this to the Backlog milestone Nov 14, 2023
@bebound
Copy link
Contributor

bebound commented Nov 14, 2023

We removed this package to reduce the docker image size in 2.54.0, See #27567
You need to install it manually.

@RaduG
Copy link

RaduG commented Nov 14, 2023

This broke lots of CI pipelines today. Zip is necessary particularly when deploying function apps. How large could the zip binary be to warrant its removal?

@TomTom0815
Copy link

TomTom0815 commented Nov 14, 2023

Today was a terrible day for our development department – CI fails all over the place.
Hunting down all the missing zip package in all CI builds was a nightmare – when the automated build process stops to deploy images to customers. 😠

Also, the comment from @bebound is only half-useful. (“You need to install it manually.”)
Sure, but if you could provide instructions HOW, you could save many developers now from researching in trying different solutions.

Just in case somone needs a quick solution:

apk update
apk add zip

@bebound
Copy link
Contributor

bebound commented Nov 15, 2023

Sorry for the inconvenient.

The reason for removing it is not only to reduce the size but also to comply with Docker's best practices.

Don't install unnecessary packages

az is the only command that always works in this Docker image.

@antgustech
Copy link

antgustech commented Nov 15, 2023

Curl has also been removed? Our CI/CD pipelines started to break and we had to revert to an older release 2.53.1. Thank you.

@RaduG
Copy link

RaduG commented Nov 15, 2023

Honestly I think this was a very poor decision. This image is used for azure-target CI, tools like curl, zip, jq are fundamental, it was a painful day indeed.

@michaelbironneau
Copy link

Very poor decision. If you're going to remove necessary tools, then please provide alternative instructions that don't require reinstalling these same tools.

@timia2109
Copy link

Is it possible to maintain two images? One minimal (only include az) and one with the same utils as the previous versions?

Personally I think it's better if Microsoft maintain two versions, instead having many community maintained images.

@AlanGRutter
Copy link

Just got hammered by this issue myself. Microsoft strikes again!!! - what a phenomenally stupid decision. Congrats on breaking everybody's CI/CD pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure CLI Team The command of the issue is owned by Azure CLI team customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

9 participants