Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL - ability to connect directly to resource provider #2832

Merged
merged 3 commits into from
Apr 14, 2017

Conversation

jaredmoo
Copy link
Member

@jaredmoo jaredmoo commented Apr 11, 2017

Use SQL RP URI and subscription id from environment variables in order to skip AAD and connect directly to the resource provider. This is used for SQL internal testing where there is no AAD/ARM frontend so the user has authority to use any subscription id.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

Copy link
Contributor

@yugangw-msft yugangw-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the style check error by adding a new empty line

@codecov-io
Copy link

Codecov Report

Merging #2832 into master will increase coverage by 0.23%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   62.88%   63.11%   +0.23%     
==========================================
  Files         464      464              
  Lines       25890    25921      +31     
  Branches     3944     3949       +5     
==========================================
+ Hits        16281    16361      +80     
+ Misses       8590     8508      -82     
- Partials     1019     1052      +33
Impacted Files Coverage Δ
...ure-cli-sql/azure/cli/command_modules/sql/_util.py 84.21% <71.42%> (-8.65%) ⬇️
...-cli-find/azure/cli/command_modules/find/custom.py 88% <0%> (-5.75%) ⬇️
...li-role/azure/cli/command_modules/role/commands.py 84.44% <0%> (-2.52%) ⬇️
...ure-cli-core/azure/cli/core/commands/parameters.py 70.96% <0%> (-2.16%) ⬇️
...torage/azure/cli/command_modules/storage/custom.py 85.83% <0%> (-1.18%) ⬇️
src/azure-cli-core/azure/cli/core/parser.py 81.37% <0%> (ø) ⬆️
...cli-role/azure/cli/command_modules/role/_params.py 100% <0%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/application.py 89.32% <0%> (+0.48%) ⬆️
src/azure-cli-core/azure/cli/core/_profile.py 85.25% <0%> (+1.07%) ⬆️
...etwork/azure/cli/command_modules/network/custom.py 63.46% <0%> (+1.08%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4769d93...d66a27c. Read the comment docs.

@yugangw-msft yugangw-msft merged commit bb5c8f6 into Azure:master Apr 14, 2017
@jaredmoo jaredmoo deleted the mockprofile2 branch April 27, 2017 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants