Enhanced Key Vault Certificate Download and AAD SP Integration #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devigned
changed the title
az ad sp create-for-rbac
yugangw-msft
approved these changes
Apr 26, 2017
devigned
changed the title
az ad sp create-for-rbac
tjprescott
suggested changes
Apr 26, 2017
| @@ -6,6 +6,7 @@ Release History | |||
| unreleased | |||
| ++++++++++++++++++++ | |||
|
|
|||
| * Change `az keyvault certificate download` to better reflect the encoding options (PEM and DER). | |||
There was a problem hiding this comment.
Since these options have changed, this is a breaking change, so please label it BC.
| @@ -73,6 +73,7 @@ def completer(prefix, action, parsed_args, **kwargs): # pylint: disable=unused-a | |||
| json_web_key_op_values = ', '.join([x.value for x in JsonWebKeyOperation]) | |||
| secret_encoding_values = secret_text_encoding_values + secret_binary_encoding_values | |||
| certificate_file_encoding_values = ['binary', 'string'] | |||
There was a problem hiding this comment.
You can delete this since it's no longer used.
| @@ -506,7 +513,8 @@ def create_service_principal_for_rbac( | |||
| '''create a service principal and configure its access to Azure resources | |||
| :param str name: a display name or an app id uri. Command will generate one if missing. | |||
| :param str password: the password used to login. If missing, command will generate one. | |||
| :param str cert: PEM formatted public certificate. Do not include private key info. | |||
| :param str cert: string or @file_path PEM formatted public certificate. Do not include private | |||
There was a problem hiding this comment.
Recommend this for consistency for where this is used elsewhere:
PEM formatted public certificate using JSON string or `@<file path>` to load from a file.
tjprescott
approved these changes
Apr 27, 2017
Codecov Report
@@ Coverage Diff @@
## master #3003 +/- ##
=========================================
- Coverage 63.17% 63.1% -0.08%
=========================================
Files 484 484
Lines 27582 27621 +39
Branches 4276 4280 +4
=========================================
+ Hits 17426 17431 +5
- Misses 9002 9034 +32
- Partials 1154 1156 +2
Continue to review full report at Codecov.
|
|
Still LGTM. Feel free to merge when you are happy 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--certaz keyvault certificate downloadto better reflect the encoding options (PEM and DER).Usage: