New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bytes returned from hex fingerprint -o tsv #3053
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
- Coverage 63.15% 63.15% -0.01%
==========================================
Files 484 484
Lines 27628 27631 +3
Branches 4281 4282 +1
==========================================
+ Hits 17449 17450 +1
- Misses 9027 9028 +1
- Partials 1152 1153 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have a test.
damn... @troydai. I knew you were going to say that. I'll add a test. |
I'm too predictable. |
Looks good but does it work with Python 2 and 3?
|
@derekbekoe should be good. I'll prove with a test.
|
The hex fingerprint of a Key Vault certificate returns as bytes in py3. This corrects that and returns a str as the method says it should.
After the fix
$ az keyvault certificate show --vault-name testvaultdj -n testcert --query "x509ThumbprintHex" -o tsv 73863FFDAD3BA0E7C08BAEFBAD09F661298341C6