Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azd config is hard to use #2051

Closed
savannahostrowski opened this issue Apr 28, 2023 · 6 comments · Fixed by #2787
Closed

azd config is hard to use #2051

savannahostrowski opened this issue Apr 28, 2023 · 6 comments · Fixed by #2787

Comments

@savannahostrowski
Copy link
Contributor

We should probably do an audit of azd config UX during Gallium.

Today, it's hard to know what you should pass into azd config get. The help text doesn't really give much insight into what the supported values are (e.g. properties in the config.json and the error message is too vague/not providing enough guidance.

@weikanglim
Copy link
Contributor

There's a lot of things we can do here.

I would love to adopt VSCode's flattened JSON file format so that the user can easily change settings in the filesystem without going through the CLI.

And as you pointed out, there should be a gesture to display the allowed settings with their descriptions.

@vhvb1989
Copy link
Member

I would love to adopt VSCode's flattened JSON file format so that the user can easily change settings in the filesystem without going through the CLI.

I don't like when users can have access to application files. That's usually not a good idea.
If we want to go this path, I suggest using user-settings file per project. Then, the global-azd app config is managed only by azd cli. If user wants to use a manual file, they could create an azd.config file within a project to override the global settings.

@weikanglim
Copy link
Contributor

weikanglim commented Jun 1, 2023

I don't like when users can have access to application files. That's usually not a good idea.

It's not the best idea for engineering and app owners, but it's worth it for the user. There's a reason why git supports both types of configurations. We're also talking about a key-value store interface, which is easily maintained and stable.

If we want to go this path, I suggest using user-settings file per project

Do you have current examples of why users might want this?

@savannahostrowski
Copy link
Contributor Author

After chatting with @vhvb1989, we are going to:

  1. Surface supported values in azd config -h
  2. When a user passes in an unsupported value, the error will tell them to run help to view permissible options.

@vhvb1989
Copy link
Member

Moved to Agoust.
Based on team's feedback, we want to have further conversation about this.
@wbreza @ellismg

We'll wait for @savannahostrowski

@savannahostrowski
Copy link
Contributor Author

Can we add more details here about why this was moved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants