Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for missing resource types #3020

Closed
7 tasks done
davidfowl opened this issue Nov 24, 2023 · 12 comments
Closed
7 tasks done

Add support for missing resource types #3020

davidfowl opened this issue Nov 24, 2023 · 12 comments
Labels
Milestone

Comments

@stuartpa
Copy link

stuartpa commented Nov 24, 2023

+1 on getting the SqlServer resource type supported. Currently hitting:

azd init
.
.
Generating files to run your app on Azure:

ERROR: unsupported resource type: sqlserver.server.v1

ASIDE: Is it a bug that the sqlserver.server resource type is v1 (set in WriteSqlServerContainerToManifest() in SqlServerBuilderExtensions.cs). Should it be v0 (like all the others)

@stuartpa
Copy link

stuartpa commented Nov 26, 2023

Is implementing the container resources for items not supported by "az appcontainer add-on create" going to be hard? For example, will azd wait until "az appcontainer add-on sqlserver" support is added before trying to implement sqlserver.server.v1 support.

My understanding is, without appcontainer add-on support for sqlserver, azd will need to do the work to config Ingress, setup a container secret (the mssql equiv to the pg-password), and also pass the required environment variables (e.g. ACCEPT_EULA and MSSQL_SA_PASSWORD).

While sqlserver is not supported by "appcontainer add-ons", will azd still move forward in supporting sqlserver.server.v1 (and do all the wiring up (Ingress/Secret/EnvVars) required in azd), or will azd wait until "az appcontianer add-on" support is added for "sqlserver"?

@vhvb1989
Copy link
Member

@stuartpa , azd does not depend on az to provide functionality.

azd interacts with appcontainer service directly, using the sdk clients.

So, no, what az supports or not does not affect azd.

@stuartpa
Copy link

Okay, same question rephrased:

While sqlserver is not supported by "appcontainer add-ons", will azd still move forward in supporting sqlserver.server.v1 (and do all the wiring up (Ingress/Secret/EnvVars) required in azd), or will azd wait until "az appcontianer add-on" support is added for "sqlserver"?

@mitchdenny
Copy link

We are working through these details at the moment. Our goal is to have it so that when azd sees a sqlserver resource that it will deploy an Azure SQL Database instance.

@davidfowl
Copy link
Member Author

davidfowl commented Jan 23, 2024

@eerhardt we need to add kafka to this list. ACA's kafka support https://learn.microsoft.com/en-us/azure/container-apps/tutorial-dev-services-kafka?tabs=bash

@eerhardt
Copy link
Member

@eerhardt we need to add kafka to this list. ACA's kafka support https://learn.microsoft.com/en-us/azure/container-apps/tutorial-dev-services-kafka?tabs=bash

Note I can't edit the top list, as I'm not a contributor in this repo.

I noticed a couple more missing as well. I've opened the following issues, if you want to add them to this list @ellismg:

@javiergardella
Copy link

@mitchdenny --> Instead of creating an 'Azure SQL Database instance,' could you set up an entire AKS with two PODs—one for SQL Server and another for the web?

I have already accomplished this, and I can provide the YAML files if needed.

@davidfowl
Copy link
Member Author

@mitchdenny --> Instead of creating an 'Azure SQL Database instance,' could you set up an entire AKS with two PODs—one for SQL Server and another for the web?

There's no support for AKS in aspire via azd for v1. We're primarily targeting ACA. aspirate can deploy SQL containers to Kubernetes.

@MiTschMR
Copy link

Also running into the ERROR: generating bicep from manifest: unsupported resource type: sqlserver.server.v1 error/bug. From what I have seen and read, sqlserver.server.v0 is not yet supported, but planned?

Would love to automatically have everything provisioned 😁

@davidfowl
Copy link
Member Author

davidfowl commented Jan 30, 2024

SQL Server will work in the next preview of azd and aspire.

@rajeshkamal5050
Copy link

We will not add hand-crafted, template-based Bicep deployment support in azd. Instead, we will be moving towards using bicep resource type and CDK effort.

@rajeshkamal5050 rajeshkamal5050 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants