Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Azure Graph calls with CLI/REST Calls? #540

Closed
jongio opened this issue Aug 29, 2022 · 2 comments
Closed

Replace Azure Graph calls with CLI/REST Calls? #540

jongio opened this issue Aug 29, 2022 · 2 comments
Assignees
Milestone

Comments

@jongio
Copy link
Member

jongio commented Aug 29, 2022

We have noticed two things:

  1. Azure Graph API calls seem to be taking longer than expected
  2. Azure Graph data seems to have a sync delay between when the resource is created in Azure and when it is available in the Azure Graph API.

Should we remove the Azure Graph calls in our main flow and replace with either REST or azcli calls?

@rajeshkamal5050 rajeshkamal5050 added this to the Release 0.2 milestone Aug 29, 2022
@weikanglim weikanglim self-assigned this Aug 29, 2022
@weikanglim
Copy link
Contributor

The guaranteed SLA for azure resource graph is: 95% of all changes to be present in resource graph under 30s. There is no upper bound on delay (likely a day or a few hours). Given these constraints, and that the initial change to adopt Azure Resource Graph was claimed performance, we should switch back to ARM APIs.

@ellismg
Copy link
Member

ellismg commented Aug 30, 2022

I think we should also explore caching some of this information locally, so we don't have to list resource groups or do other operations to "discover" resources every time the CLI boots. It seems like after an azd provision we should be able to take the set of provisioned resources, query the "interesting" ones (I think this will be based on RP, for RPs we know do compute and may be tied to an azd service) and then query their tags and save a mapping, so we can quickly correlate service names to resource IDs.

For Terraform and Pulumi it's probably easier since the state file would contain all of this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants