Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which host name do I have to specify? Every option returns 404 #151

Open
atsapura opened this issue Jun 22, 2020 · 2 comments
Open

Which host name do I have to specify? Every option returns 404 #151

atsapura opened this issue Jun 22, 2020 · 2 comments

Comments

@atsapura
Copy link

No description provided.

@mkolt
Copy link
Contributor

mkolt commented Jun 23, 2020

Typically you would choose any unique per lease collection name. If you have many feeds in the same lease collection, you may include random GUID. If you continue getting 404s, provide stack trace and some sample code.

@atsapura
Copy link
Author

atsapura commented Jun 24, 2020

Alright, that wasn't about host name as it turned out. The reason was that lease collection wasn't created in advance. So here are my thoughts on that:

  • Docs can be improved about this parameter/method WithHostName, since sets the host name to me was completely obscure, and I didn't get the meaning behind this parameter.

  • Would be really nice to have more info in error response about what exactly wasn't found, since 404 status doesn't tell you much when there're several parameters at play: the feed collection might not be found, the lease collection, the database itself and who knows what else.

  • Would be cool to move mandatory parameters like hostName to builder constructor rather then having them as With... methods, since it's unclear which With... methods are required and which are optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants