Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-extension-manifest does not generates a proper XML output #35

Open
Nimesh-Msys opened this issue Dec 20, 2018 · 2 comments
Open

new-extension-manifest does not generates a proper XML output #35

Nimesh-Msys opened this issue Dec 20, 2018 · 2 comments

Comments

@Nimesh-Msys
Copy link

While trying to execute the following command with CLI Version 1.2.4, we do get a proper expected XML output. But it doesn't works well with later versions.

Command

azure-extensions-cli_linux_amd64 new-extension-manifest \
--management-url URL \
--subscription-id ID \
--subscription-cert Cert \
--package Package \
--storage-base-url core.windows.net \
--storage-account Account \
--namespace Namespace \
--name Name \
--version Version \
--label Custom-Label \
--description Custom-Desc \
--eula-url EULA-URL \
--privacy-url Privacy-URL \
--homepage-url Homepage \
--company My-Company \
--supported-os windows

Output with CLI v1.2.7 & 1.2.6:

<ExtensionImage xmlns="">
  <ProviderNameSpace>Namespace</ProviderNameSpace>
  <Type>Name</Type>
  <Version>Version</Version>
  <Label>label</Label>
  <HostingResources></HostingResources>
  <MediaLink>ZIP</MediaLink>
  <Endpoints></Endpoints>
  <Description>description</Description>
  <LocalResources></LocalResources>
  <IsInternalExtension>true</IsInternalExtension>
  <Eula>eula-url</Eula>
  <PrivacyUri>privacy-url</PrivacyUri>
  <HomepageUri>homepage-url</HomepageUri>
  <IsJsonExtension>true</IsJsonExtension>
  <CompanyName>company</CompanyName>
  <SupportedOS>supported-os</SupportedOS>
</ExtensionImage>

Expected Output (Working till v1.2.4)

<?xml version="1.0" encoding="utf-8" ?>
<ExtensionImage xmlns="http://schemas.microsoft.com/windowsazure"  xmlns:i="http://www.w3.org/2001/XMLSchema-instance">
  <!-- WARNING: Ordering of fields matter in this file. -->
  <ProviderNameSpace>Namespace</ProviderNameSpace>
  <Type>Name</Type>
  <Version>Version</Version>
  <Label>Custom-Label</Label>
  <HostingResources>VmRole</HostingResources>
  <MediaLink>Zip</MediaLink>
  <Description>Custom-Desc</Description>
  <IsInternalExtension>true</IsInternalExtension>
  <Eula>EULA-URL</Eula>
  <PrivacyUri>Privacy-URL</PrivacyUri>
  <HomepageUri>Homepage</HomepageUri>
  <IsJsonExtension>true</IsJsonExtension>
  <CompanyName>My-Company</CompanyName>
  <SupportedOS>windows</SupportedOS>
  <!--%REGIONS%-->
</ExtensionImage>

What we see here is, only few user inputs are considered. We don't see any changes in help topics of new-extension-manifest. Is there anything we need to take care of or this PR might need to be revisited

@Nimesh-Msys
Copy link
Author

Any update on this ?

@stuartpreston
Copy link

@boumenot @roiyz-msft Any advice you can give to @Nimesh-Msys here would be appreciated - we can only currently use the tool at 1.2.4 to promote a single region, two regions or all regions but would like to use the new approach (specifying the region property multiple times for the number of regions to target in that round)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants