Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we determine which extensions support deferred binding #1266

Closed
3 tasks done
liliankasem opened this issue Jan 11, 2023 · 0 comments · Fixed by #1275
Closed
3 tasks done

Refactor how we determine which extensions support deferred binding #1266

liliankasem opened this issue Jan 11, 2023 · 0 comments · Fixed by #1275
Assignees
Labels

Comments

@liliankasem
Copy link
Member

liliankasem commented Jan 11, 2023

Today we have have a single SupportsDeferredBinding attribute that extensions can set to indicate that ParameterBindingData can be used (i.e. the extension supports sdk-type bindings). This is used by the FunctionMetadataGenerator to set the "supportsDeferringBinding" property for every function.

The goal for this issue is to refactor the SupportsDeferredBinding attribute so that instead of being a blanket "all or nothing" approach for extensions, we can set the supportsDeferredBinding flag per binding instead. For example, the CosmosDBTrigger does not support deferred binding but we can use deferred binding for the input binding.

  • Remove the SupportsDeferredBinding property from the ExtensionInformationAttribute
  • Implement an attribute that binding attributes can use to set SupportsDeferredBinding to true or false
  • Update the FunctionMetadataGenerator to remove the code that gets the supportsDeferredBinding flag from ExtensionInformationAttribute, and to get that information from the CustomAttribute instead
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant