Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traces with IsReplay=false not correctly filtered out in Application Insights #1351

Closed
AtOMiCNebula opened this issue May 14, 2020 · 2 comments · Fixed by #1352
Closed

Traces with IsReplay=false not correctly filtered out in Application Insights #1351

AtOMiCNebula opened this issue May 14, 2020 · 2 comments · Fixed by #1352
Assignees
@cgillum
Labels
bug
Milestone
Extension v2.3.0

Comments

@AtOMiCNebula
Copy link
Contributor

Description

EndToEndTraceHelper is not honoring the TraceReplayEvents option parameter for the following event types, due to what appears to be a copy-paste error:

  • ExternalEventRaised
  • ExternalEventSaved
  • TimerExpired

As we scale up our durable function-using application, we've seen indications in App Insights that sampling is occurring, and we are seeing a ton of trace logging happening for replay events (even though that is disabled by default). Over the last 24 hours, our app has collected 31K traces with IsReplay=true (should be 0 😇), 27K with IsReplay=false, and 39K with IsReplay not specified (not all the trace helpers emit a value).

I'll be pushing a PR for this shortly. 😄

Expected behavior

Traces are not logged for replayed orchestrator events.

Actual behavior

Traces are being logged for replayed orchestrator events.

App Details

  • Durable Functions extension version (e.g. v1.8.3): 2.2.0
  • Azure Functions runtime version (1.0 or 2.0): 3.0
  • Programming language used: C#
@ghost ghost added the Needs: Triage 🔍 label May 14, 2020
@AtOMiCNebula AtOMiCNebula changed the title EndToEndTraceHelper generating excessive logging for some event types EndToEndTraceHelper generating excessive/undesired logging for some event types May 14, 2020
@AtOMiCNebula AtOMiCNebula mentioned this issue May 14, 2020
Merged
@AtOMiCNebula
Copy link
Contributor Author

@amdeel, looks like you've been helping with triaging lately. Can you help me get some eyes on this? 😄

@cgillum cgillum added this to the v2.3.0 milestone Jun 16, 2020
@cgillum cgillum self-assigned this Jun 16, 2020
@cgillum cgillum changed the title EndToEndTraceHelper generating excessive/undesired logging for some event types Traces with IsReplay=false not correctly filtered out in Application Insights Jun 16, 2020
@cgillum
Copy link
Collaborator

cgillum commented Jun 16, 2020

Thanks for reporting this and for the PR! We'll include this fix as part of our next planned release (v2.3.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgillum cgillum

Labels
bug
Projects
None yet
Milestone
Extension v2.3.0
2 participants
@AtOMiCNebula @cgillum