Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the 'this' parameter for azure functions #1702

Closed
mamaso opened this issue Jul 24, 2017 · 4 comments
Closed

Support the 'this' parameter for azure functions #1702

mamaso opened this issue Jul 24, 2017 · 4 comments
Assignees
@mamaso
Labels
breaking-change
Milestone
Backlog

Comments

@mamaso
Copy link
Contributor

mamaso commented Jul 24, 2017

When calling the function we don't set the 'this' parameter, see (https://github.com/Azure/azure-webjobs-sdk-script/blob/dev/src/WebJobs.Script/azurefunctions/functions.js#L93)

This should be changed to pass the user module.

https://www.reddit.com/r/AZURE/comments/6n3ldo/im_noticing_that_azure_functions_seem_to_not/
@mamaso mamaso mentioned this issue Jul 25, 2017
Closed
@christopheranderson
Copy link
Contributor

Can we say for certain this isn't a breaking change? Is there any pattern this could break? We're close to 2.0, should we save the concern?

@christopheranderson
Copy link
Contributor

@paulbatum votes this is breaking. Let's just move this to 2.0 only.

@christopheranderson christopheranderson added this to the Triaged milestone Jul 31, 2017
@mamaso
Copy link
Contributor Author

mamaso commented Jul 31, 2017

Fair enough :)

@paulbatum paulbatum modified the milestones: Triaged, Next Aug 10, 2017
@mamaso mamaso mentioned this issue Aug 10, 2017
Closed
@mamaso
Copy link
Contributor Author

mamaso commented Aug 10, 2017

Moved to worker repo

@mamaso mamaso closed this as completed Aug 10, 2017
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mamaso mamaso

Labels
breaking-change
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Call function with 'this' parameter if appropriate mamaso/azure-webjobs-sdk-script
3 participants
@paulbatum @christopheranderson @mamaso