Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus Config Options have changed #2828

Closed
mathewc opened this issue May 10, 2018 · 6 comments
Closed

ServiceBus Config Options have changed #2828

mathewc opened this issue May 10, 2018 · 6 comments
Assignees
Labels

Comments

@mathewc
Copy link
Member

mathewc commented May 10, 2018

After the v2 extension migration, the underlying SB SDK has changed, but we haven't updated our schema files and/or documentation. E.g. autoRenewTimeout no longer exists in SB, so our schema is out of date here.

We actually need to verify that SB configuration works in v2 from Functions host.json. We used to do this here in v1. Where does this logic exist now? In v2 I believe we're relying on the new generalized logic here. That suggests a new config format like:

{
    "serviceBus": {
        "messageOptions": {
            "maxAutoRenewDuration": "00:05:00"
            "maxConcurrentCalls": 5
        }
    }
}

We need to make sure this logic correctly handles string -> TimeSpan conversions, etc.

@paulbatum
Copy link
Member

Retest this after the DI work is merged.

@paulbatum paulbatum added this to the Triaged milestone May 23, 2018
@paulbatum paulbatum modified the milestones: Triaged, Sprint 25 May 30, 2018
@paulbatum paulbatum modified the milestones: Sprint 25, Sprint 26 Jun 13, 2018
@alrod alrod modified the milestones: Sprint 26, Functions Sprint 27 Jun 27, 2018
@alrod alrod added the blocked label Jun 27, 2018
@mathewc
Copy link
Member Author

mathewc commented Jul 26, 2018

In #3179 I added the ability to configure AutoResolve. In v2 the config model has changed, and DI is changing the model more. After that work is done, we need to revisit and verify that users can configure all these settings.

@fabiocav
Copy link
Member

We should be able to address this now

@jonbjo
Copy link

jonbjo commented Aug 30, 2018

This issue being resolved, does that mean that the next release will pick up maxAutoRenewDuration maxConcurrentCalls if they are defined in host.json according to https://github.com/Azure/azure-functions-host/blob/dev/schemas/json/host.json#L261?

Will it make it into next release of azure-functions-core-tools (2.0.1-beta.36)? ETA?
What is the ETA for this to work in production?

@mathewc
Copy link
Member Author

mathewc commented Aug 30, 2018

Yes, as shown in the unit test here. Those are the raw config system paths - similar paths will work for the host.json configuration source.

These changes are in the current release that is rolling out now: https://github.com/Azure/azure-functions-host/releases/tag/v2.0.12050-alpha.

@paulbatum
Copy link
Member

To make it more explicit - see the example here:
https://github.com/Azure/azure-functions-host/wiki/host.json-(v2)

@Azure Azure locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants