New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceBus Config Options have changed #2828
Comments
Retest this after the DI work is merged. |
In #3179 I added the ability to configure AutoResolve. In v2 the config model has changed, and DI is changing the model more. After that work is done, we need to revisit and verify that users can configure all these settings. |
We should be able to address this now |
This issue being resolved, does that mean that the next release will pick up maxAutoRenewDuration maxConcurrentCalls if they are defined in host.json according to https://github.com/Azure/azure-functions-host/blob/dev/schemas/json/host.json#L261? Will it make it into next release of azure-functions-core-tools (2.0.1-beta.36)? ETA? |
Yes, as shown in the unit test here. Those are the raw config system paths - similar paths will work for the host.json configuration source. These changes are in the current release that is rolling out now: https://github.com/Azure/azure-functions-host/releases/tag/v2.0.12050-alpha. |
To make it more explicit - see the example here: |
After the v2 extension migration, the underlying SB SDK has changed, but we haven't updated our schema files and/or documentation. E.g. autoRenewTimeout no longer exists in SB, so our schema is out of date here.
We actually need to verify that SB configuration works in v2 from Functions host.json. We used to do this here in v1. Where does this logic exist now? In v2 I believe we're relying on the new generalized logic here. That suggests a new config format like:
We need to make sure this logic correctly handles string -> TimeSpan conversions, etc.
The text was updated successfully, but these errors were encountered: