Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding metrics not emitted for in-proc precompiled applications #8059

Closed
fabiocav opened this issue Jan 13, 2022 · 4 comments
Closed

Binding metrics not emitted for in-proc precompiled applications #8059

fabiocav opened this issue Jan 13, 2022 · 4 comments
Assignees
@kshyju
Labels
bug Logging and Metrics

Comments

@fabiocav
Copy link
Member

This is a gap that seems to date back to the initial implementation of direct load (WebJobs loaded Functions), and our FunctionMetadata instance is not fully populated with binding information for that scenario, causing the host to miss metric logging for input and output bindings.

We need to ensure metrics are correctly emitted so we have accurate information for binding usage.
@ghost ghost assigned brettsam Jan 13, 2022
@fabiocav fabiocav added this to the Functions Sprint 117 milestone Jan 13, 2022
@kshyju
Copy link
Member

kshyju commented Feb 8, 2022

PR with the fix: Azure/azure-functions-vs-build-sdk#542

@kshyju
Copy link
Member

kshyju commented Feb 25, 2022

Sdk.Functions package 4.1.0 which has the fix for this, is now available in nuget gallery.

https://www.nuget.org/packages/Microsoft.NET.Sdk.Functions/4.1.0

@fabiocav
Copy link
Member Author

fabiocav commented Mar 2, 2022

Closing as resolved by Azure/azure-functions-vs-build-sdk#542

@fabiocav fabiocav closed this as completed Mar 2, 2022
@kshyju kshyju mentioned this issue Mar 4, 2022
Merged
@kshyju
Copy link
Member

kshyju commented Mar 21, 2022

V3 version of the package with this fix is now available in nuget gallery.

https://www.nuget.org/packages/Microsoft.NET.Sdk.Functions/3.1.0

@ghost ghost locked as resolved and limited conversation to collaborators Apr 20, 2022
@fabiocav fabiocav modified the milestones: Functions Sprint 117, Left Overs Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kshyju kshyju

Labels
bug Logging and Metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kshyju @brettsam @fabiocav