Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CORS configuration via environment variables when not running in Linux consumption #8936

Closed
anthonychu opened this issue Nov 24, 2022 · 0 comments · Fixed by #9846
Closed
Assignees

Comments

@anthonychu
Copy link
Member

What problem would the feature you're requesting solve? Please describe.

Currently, it's possible to configure CORS via environment variables, but the variables are only used when running in Linux consumption:

It can be useful to configure CORS via environment variables, such as when running in a container. Would be great to allow this.

Describe the solution you'd like

Allow CORS configuration via environment variables when running outside Linux consumption.

Describe alternatives you've considered

Setting a variable named CONTAINER_NAME will cause the host to go down the same code path as Linux consumption, but on environments such as Container Apps or Kubernetes, setting that variable will provide the same container name to all running replicas/pods. This might have unintended consequences if other parts of the host uses the container name and expects it to be unique per host instance.

Additional context

Thread: https://hachyderm.io/@anthonychu/109400532768512364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants