Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify partition key on EventHub output binding #18

Closed
jeffhollan opened this issue Jun 20, 2018 · 11 comments
Closed

Add support to specify partition key on EventHub output binding #18

jeffhollan opened this issue Jun 20, 2018 · 11 comments
Assignees

Comments

@jeffhollan
Copy link

Today for C# functions if you send EventData type to the output binding you can define a system property for partition key which is honored when sending the message. Today the Java output binding appears to only support string or byte [] which give no way to specify partition key

@asavaritayal asavaritayal modified the milestones: Backlog, Triaged Oct 5, 2018
@pragnagopa pragnagopa self-assigned this Oct 19, 2018
@pragnagopa pragnagopa changed the title Allow specification of partition key for EventHub output binding Add sample and E2E test that test that specifies partition key on EventHub output binding Oct 19, 2018
@pragnagopa
Copy link
Member

PartitionKey is part of the metadata properties. https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-event-hubs#trigger---event-metadata Sending a POJO with partitionkey should work.
Need to try and add E2E test.

@pragnagopa pragnagopa changed the title Add sample and E2E test that test that specifies partition key on EventHub output binding Add sample and E2E test that specifies partition key on EventHub output binding Oct 19, 2018
@pragnagopa pragnagopa changed the title Add sample and E2E test that specifies partition key on EventHub output binding Add support to specify partition key on EventHub output binding Oct 24, 2018
@pragnagopa
Copy link
Member

cc: @mhoeger
partitionKey is part of the metadata. As of now there is no support for sending metadata as part of invocation response that is defined in the protobuff FunctionRpc.proto#L245-L257

@pragnagopa
Copy link
Member

cc: @paulbatum

@pragnagopa
Copy link
Member

cc @kulkarnisonia16

@pragnagopa
Copy link
Member

Related issue on EventHubs extension: Azure/azure-sdk-for-net#28245

@pragnagopa
Copy link
Member

given the context in Azure/azure-sdk-for-net#28245, @amamounelsayed please sync up @alrod before finalizing structure of the EventHubMessage Type.

@pragnagopa
Copy link
Member

cc @mathewc
Related issue Azure/azure-functions-host#364. As of now webjobs sdk does
not support setting any properties on the output binding via IAsyncCollector.

Note: AsyncCollector.cs is used by functions host to send output binding content to extensions sdk

@pragnagopa
Copy link
Member

@amamounelsayed - Please look through table extension sdk and to confirm how partitionkey is being set on the output binding

@pragnagopa
Copy link
Member

@fabiocav
Copy link
Member

This is being handled with an out-of-band update. Closing as there's no action to be taken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants