Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have TLS client certificates auth #67

Closed
agowdamsft opened this issue Apr 10, 2019 · 5 comments
Closed

Should have TLS client certificates auth #67

agowdamsft opened this issue Apr 10, 2019 · 5 comments
Assignees
Milestone

Comments

@agowdamsft
Copy link

Cert based auth is very typical with Kafka especailly when you have func running on a container or on Azure where Kafka clusters are running on VM/Confulent Cloud. Having this support could be important to target production workloads.

@ryancrawcour ryancrawcour changed the title Good to have TLS client certificates auth Should have TLS client certificates auth Apr 10, 2019
@ryancrawcour ryancrawcour added this to the P1 milestone Apr 10, 2019
@fbeltrao
Copy link
Contributor

Where would such certificates be stored?

  • Key Vault when running on service plan?
  • Secrets when running in K8s?

@agowdamsft
Copy link
Author

KV would be very Azure based appraoch I would like to have that as an option. but any thoughts to have secrets as part of application seetings (SaslUsername & Password) with Client Cert as part of the App as file ? (not sure if we can leverage ssl cert store as this could be only applicable for app service plan- i am guessing) (. More ref here https://github.com/confluentinc/confluent-kafka-dotnet/blob/master/examples/ConfluentCloud/Program.cs

@ryancrawcour
Copy link
Contributor

There is a PR open for this @agowdamsft could you please take a look through #78 and see if you approve.
I would add you as reviewer, but i can't for some reason.
Probably because you're not a member of the team / org or something.

@agowdamsft
Copy link
Author

agowdamsft commented Apr 15, 2019 via email

@ryancrawcour
Copy link
Contributor

No. I do not believe you missed it. @fbeltrao did open a new issue #77 to go back and add tests, which is likley where the "example" will be. Will merge this for now, and if you find an issue after you've tried it yourself, or after the tests are published, we can always reopen the issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants