Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkerOptions to have a URI property instead of host name and port number #994

Open
Francisco-Gamino opened this issue Sep 8, 2023 · 0 comments
Assignees
Labels

Comments

@Francisco-Gamino
Copy link
Contributor

This is related to #992.

We are updating the logic to parse command-line arguments that the PowerShell language worker receives from the Functions Host. Currently, we are adding support to parse the new arguments, which are prefixed with functions-.

After the Functions Host changes have propagated, and we have a Core Tools version with this new Functions Host, we should remove parsing support for the old arguments. When doing this work, we should also consider adding a Uri property to the WorkerOptions type and assigning workerArgs.FunctionsUri to it. With this update, we can avoid rebuilding the uri string inside the MessagingStream method and pass the WorkerOptions instance to that method instead.

@Francisco-Gamino Francisco-Gamino changed the title Update MessagingStream constructor to take a URI instead of host name and port number Update WorkerOptions to have a URI property instead of host name and port number Sep 8, 2023
@Francisco-Gamino Francisco-Gamino self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant