Fixes #112 and cleans up readers and stream #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI for one of the builds reports "An error occurred while generating the build script." Uncertain if that has anything to do with this PR. Don't see what I've messed up. I can see the former builds failing as I used newer C# constructs. |
Reducing one try-catch construct as one has been introduced at higher level and can deal with the lower-level case. Also uses switch expression to get somewhat cleaner code.
There is no need to try and indentify the message if not an int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112 by ensuring
StreamReaderandStreamis disposed as well as closing theJsonTextReader. The current implementation ofClosein theJsonTextReaderdisposes the passedStreamReaderbut that should be the callers concerns in my opinion. Could do just a call toCloseif that's preferred.