Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support diagnostic client #278

Open
drdamour opened this issue Sep 24, 2021 · 4 comments
Open

support diagnostic client #278

drdamour opened this issue Sep 24, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@drdamour
Copy link

be nice if there was a way to mark my client as diagnostic, maybe just a host.json setting or possibly in the attr itself

@Y-Sindo
Copy link
Member

Y-Sindo commented Sep 27, 2021

If you are using C#, you could try the ServerlessHub.NegotiateAsync method and set the NegotiationOptions.IsDiagnosticClient to true. If you are using other languages, currently there is no way to do this. Will put this feature request into our backlog.

@Y-Sindo Y-Sindo added the enhancement New feature or request label Sep 27, 2021
@drdamour
Copy link
Author

@Y-Sindo i am c#, but not following recommendation. All i'm getting injected is an IAsyncCollector

@Y-Sindo
Copy link
Member

Y-Sindo commented Sep 27, 2021

Whether a client is diagnostic is decided when the client negotiates (get the client url and access token), which is irrelevant to how you send your messages, IAsyncCollector, etc. You are possible to use SignalRConnectionInfo input binding to negotiate your client and SignalRConnectionInfo has no ability to mark a client as diagnostic. But you can use another model : ServerlessHub to do the negotiation, see here for a sample. Don't forget to set the NegotiationOptions.IsDiagnosticClient to true.

Read more about negotiation: https://docs.microsoft.com/en-us/azure/azure-signalr/signalr-concept-serverless-development-config#negotiate-function

@drdamour
Copy link
Author

@Y-Sindo thx I understand now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants