Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable attribute with string parameter should write string to function.json #85

Closed
lindydonna opened this issue Aug 3, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@lindydonna
Copy link

lindydonna commented Aug 3, 2017

Do the following:

  • Match against a regex of alphanumeric strings. Anything else is a build error.
  • If %setting% is used, build error should say '%' expressions are not supported for 'Disable'. Use 'Disable("setting") instead of 'Disable("%setting%")'
  • [Disable("setting")] writes "disabled": "setting" to function.json
  • Build error if they use constructor DisableAttribute(Type providerType). Error: the constructor 'DisableAttribute(Type)' is not supported.

I'll update the doccomment for DisableAttribute so that it's clear that the extra features work only in WebJobs.

@lindydonna lindydonna added this to the 1.0 milestone Aug 3, 2017
@lindydonna lindydonna added the bug label Aug 3, 2017
@MikeStall
Copy link

The driving factor here is that whatever the tooling emits cooperates with the existing function.json spec around disabled; and if it's not supported in function.json today, then the tooling emits a error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants