Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectionState property not visible in com.microsoft.azure.sdk.iot.service.devicetwin.DeviceTwinDevice #520

Closed
pawankaushal opened this issue May 17, 2019 · 10 comments
Assignees
Labels
bug fix checked in Fix checked into main or preview, but not yet released.

Comments

@pawankaushal
Copy link

pawankaushal commented May 17, 2019

We are building our application on Azure IOT platform and we need to get connection status for a device but unfortunately the property is not available in POJO DeviceTwinDevice. Please see the feasibility of adding this field.

PS: I can see the JSON document for a device coming from hub response clearly has the property connectionState.

@timtay-microsoft
Copy link
Member

You are correct, the SDK should be propagating that field up through the deviceTwinDevice object. I'm working to fix this issue.

@pawankaushal
Copy link
Author

pawankaushal commented May 21, 2019

Thanks for addressing this. Would be much nicer if we can have a milestone/patch release so that we can incorporate the changes quickly? sorry By mistake I closed this and now reverted this as opened again.

  • Regards
    Pawan Kaushal

@az-iot-builder-01
Copy link
Collaborator

@pawankaushal, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

@pawankaushal pawankaushal reopened this May 24, 2019
@timtay-microsoft timtay-microsoft added the fix checked in Fix checked into main or preview, but not yet released. label May 30, 2019
@timtay-microsoft
Copy link
Member

This fix has been checked into master, and we are planning to do a release tomorrow (5/31)

@pawankaushal
Copy link
Author

This fix has been checked into master, and we are planning to do a release tomorrow (5/31)

Thanks for the update , what would the version number for the build?

pawankaushal added a commit to pawankaushal/azure-iot-sdk-java that referenced this issue Jun 4, 2019
Connection State is now properly propagated to DeviceTwinDevice object
along with Configurations
@pawankaushal
Copy link
Author

ConnectionState coming as null irrespective of state at iot hub as it was not captured in DeviceTwin class. Please see and review the fix.
#535

@pawankaushal
Copy link
Author

@timtay-microsoft , do you see the possibility of merging my PR and adding your unit tests on top of it?

@pawankaushal
Copy link
Author

pawankaushal commented Jun 14, 2019

@timtay-microsoft , i saw a recent release , but looks like this bug is still not fixed in the current release. We are partners with Azure (lets have a private conversation to discuss this)and our product is based on the IOT platform, would appreciate if you can send us a patch release to work with post merging either PR# 535 or PR # 536.

@timtay-microsoft timtay-microsoft removed the fix checked in Fix checked into main or preview, but not yet released. label Jun 17, 2019
@pawankaushal
Copy link
Author

Hi @timtay-microsoft , @jasmineymlo , @davilu , I believe the code is ready to be merged #535 or #536. Can you please put this into upcoming release? Appreciate a quick reply!

@timtay-microsoft timtay-microsoft added the fix checked in Fix checked into main or preview, but not yet released. label Jul 9, 2019
@timtay-microsoft
Copy link
Member

As of this release, this bug has been fixed. As such, I am closing this thread. Thanks for providing the code needed to fix this bug, @pawankaushal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix checked in Fix checked into main or preview, but not yet released.
Projects
None yet
Development

No branches or pull requests

3 participants