Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question/Feedback]: Code Review - Linting & Link Checks / Markdown Link Check (pull_request) Failing #204

Open
1 task done
humblejay opened this issue Apr 29, 2024 · 1 comment
Open
1 task done

[Question/Feedback]: Code Review - Linting & Link Checks / Markdown Link Check (pull_request) Failing #204

humblejay opened this issue Apr 29, 2024 · 1 comment
Assignees
@JoeyBarnes
Labels
question Further information is requested

Comments

@humblejay
Copy link
Contributor

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

All the PRs to this repo are failing at "Code Review - Linting & Link Checks / Markdown Link Check (pull_request)" possibly due to following issues -

  1. The gaurav-nelson/github-action-markdown-link-check@1.0.15 utility is configured to check all files, not just those modified in the PR. "check-modified-files-only": no instead of yes.
  2. The markdown link check has two open issues
  • DDos protected links are marked as failed, although they open in browser link
  • Anchor link checksing fails link
@humblejay humblejay added the question Further information is requested label Apr 29, 2024
@JoeyBarnes
Copy link
Collaborator

  1. Fixed in an upcoming PR
  2. These will require a little more research and I don't have an ETA yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeyBarnes JoeyBarnes

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humblejay @JoeyBarnes