Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-AzApiManagementProduct -SubscriptionsLimit documentation #10472

Closed
dcbrown16 opened this issue Nov 4, 2019 · 5 comments
Closed

New-AzApiManagementProduct -SubscriptionsLimit documentation #10472

dcbrown16 opened this issue Nov 4, 2019 · 5 comments
Assignees
Labels
API Management customer-reported Service Attention This issue is responsible by Azure service team.

Comments

@dcbrown16
Copy link

The -SubscriptionsLimit parameter of New-AzApiManagementProduct is described with "The default value is 1" and then "Default value: None". In testing it seems that none is correct. Please remove or change the document referring to default value of 1.

-SubscriptionsLimit
Specifies the maximum number of simultaneous subscriptions. The default value is 1.
Type: System.Nullable`1[System.Int32]
Parameter Sets: (All)
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False

I don't know where to file this but the API subscription for the same parameter also needs an edit to remove the extraneous "Whether" at the beginning.

https://docs.microsoft.com/en-us/rest/api/apimanagement/2019-01-01/product/get#productcontract

Whether the number of subscriptions a user can have to this product at the same time. Set to null or omit to allow unlimited per user subscriptions. Can be present only if subscriptionRequired property is present and has a value of false.

@isra-fel isra-fel added customer-reported API Management Service Attention This issue is responsible by Azure service team. and removed triage labels Nov 5, 2019
@ghost
Copy link

ghost commented Nov 5, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @mjconnection

1 similar comment
@ghost
Copy link

ghost commented Nov 5, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @mjconnection

@dcbrown16
Copy link
Author

Further feedback here.
For New-AzApiManagementProduct, if you specify NEITHER -SubscriptionRequired NOR -SubscriptionsLimit, the default values leave you with required=true and limit=null. However, if you do specify only -SubscriptionRequired (as $True), but don't specify -SubscriptionsLimit, the limit value becomes 1. I guess that's how the -SubscriptionsLimit section of the doc says both "The default value is 1" and "Default value: None" but this is confusing and needs to be updated.

@solankisamir
Copy link
Member

@lalitkhoslarogers
Copy link

Further feedback here.
For New-AzApiManagementProduct, if you specify NEITHER -SubscriptionRequired NOR -SubscriptionsLimit, the default values leave you with required=true and limit=null. However, with this even -ApprovalRequired set to $True .. value set for Approval is False and its unchecked in the portal.. Is it a bug ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Management customer-reported Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

4 participants