IoTHub doesn't handle deletion correctly

[tombuildsstuff]

👋

Hey - so we've been working through this PR hashicorp/terraform-provider-azurerm#887 which adds support for IoTHubs to Terraform, via the Azure SDK for Go (v12.5.0-beta, but it appears this is also present in v14 / the latest, so I believe it to be a valid bug).

We're encountering a bug when attempting to delete the IoTHub that appears to be a bug in the Swagger; when deleting the IoTHub a long-running operation (LRO) is returned:

DELETE /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/tom-devrg/providers/Microsoft.Devices/IotHubs/tom-iothub?api-version=2017-07-01 HTTP/1.1
Host: management.azure.com
User-Agent: Go/go1.9.3 (amd64-darwin) go-autorest/8.0.0 Azure-SDK-For-Go/v12.5.0-beta services;HashiCorp-Terraform-v0.10.6
Authorization: Bearer REDACTED
Accept-Encoding: gzip

.. which initially returns a 200 OK:

HTTP/1.1 200 OK
Cache-Control: no-cache
Pragma: no-cache
Transfer-Encoding: chunked
Content-Type: application/json; charset=utf-8
Content-Encoding: gzip
Expires: -1
Vary: Accept-Encoding
Server: Microsoft-HTTPAPI/2.0
x-ms-ratelimit-remaining-subscription-reads: 14963
x-ms-request-id: 6b3ef430-6462-4a81-b62b-c88bac788960
x-ms-correlation-request-id: 6b3ef430-6462-4a81-b62b-c88bac788960
x-ms-routing-request-id: CANADAEAST:20180314T212325Z:6b3ef430-6462-4a81-b62b-c88bac788960
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
Date: Wed, 14 Mar 2018 21:23:24 GMT

{"status":"Running"}

.. and subsequently with a 404:

HTTP/1.1 404 Not Found
Cache-Control: no-cache
Pragma: no-cache
Content-Type: application/json; charset=utf-8
Expires: -1
x-ms-failure-cause: gateway
x-ms-request-id: b02634b1-e845-40d9-8cf3-bcfcd12ac0e8
x-ms-correlation-request-id: b02634b1-e845-40d9-8cf3-bcfcd12ac0e8
x-ms-routing-request-id: CANADAEAST:20180314T212527Z:b02634b1-e845-40d9-8cf3-bcfcd12ac0e8
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
Date: Wed, 14 Mar 2018 21:25:26 GMT
Content-Length: 149

{"error":{"code":"ResourceNotFound","message":"The Resource 'Microsoft.Devices/IotHubs/tom-iothub' under resource group 'tom-devrg' was not found."}}

which should be detected by the SDK as a successfully deleted status code, however it continues polling until the timeout is reached in our case, an hour), at which point an error is thrown:

Would it be possible to fix the Swagger so the SDK can return successful when deleted?

Thanks!

[anuchandy]

@akumardu can you please take a look or route this to right team

[tombuildsstuff]

ping @akumardu :)

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @rkmanda, @chieftn.

Issue Details

---

👋

Hey - so we've been working through this PR hashicorp/terraform-provider-azurerm#887 which adds support for IoTHubs to Terraform, via the Azure SDK for Go (v12.5.0-beta, but it appears this is also present in v14 / the latest, so I believe it to be a valid bug).

We're encountering a bug when attempting to delete the IoTHub that appears to be a bug in the Swagger; when deleting the IoTHub a long-running operation (LRO) is returned:

DELETE /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/tom-devrg/providers/Microsoft.Devices/IotHubs/tom-iothub?api-version=2017-07-01 HTTP/1.1
Host: management.azure.com
User-Agent: Go/go1.9.3 (amd64-darwin) go-autorest/8.0.0 Azure-SDK-For-Go/v12.5.0-beta services;HashiCorp-Terraform-v0.10.6
Authorization: Bearer REDACTED
Accept-Encoding: gzip

.. which initially returns a 200 OK:

HTTP/1.1 200 OK
Cache-Control: no-cache
Pragma: no-cache
Transfer-Encoding: chunked
Content-Type: application/json; charset=utf-8
Content-Encoding: gzip
Expires: -1
Vary: Accept-Encoding
Server: Microsoft-HTTPAPI/2.0
x-ms-ratelimit-remaining-subscription-reads: 14963
x-ms-request-id: 6b3ef430-6462-4a81-b62b-c88bac788960
x-ms-correlation-request-id: 6b3ef430-6462-4a81-b62b-c88bac788960
x-ms-routing-request-id: CANADAEAST:20180314T212325Z:6b3ef430-6462-4a81-b62b-c88bac788960
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
Date: Wed, 14 Mar 2018 21:23:24 GMT

{"status":"Running"}

.. and subsequently with a 404:

HTTP/1.1 404 Not Found
Cache-Control: no-cache
Pragma: no-cache
Content-Type: application/json; charset=utf-8
Expires: -1
x-ms-failure-cause: gateway
x-ms-request-id: b02634b1-e845-40d9-8cf3-bcfcd12ac0e8
x-ms-correlation-request-id: b02634b1-e845-40d9-8cf3-bcfcd12ac0e8
x-ms-routing-request-id: CANADAEAST:20180314T212527Z:b02634b1-e845-40d9-8cf3-bcfcd12ac0e8
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
Date: Wed, 14 Mar 2018 21:25:26 GMT
Content-Length: 149

{"error":{"code":"ResourceNotFound","message":"The Resource 'Microsoft.Devices/IotHubs/tom-iothub' under resource group 'tom-devrg' was not found."}}

which should be detected by the SDK as a successfully deleted status code, however it continues polling until the timeout is reached in our case, an hour), at which point an error is thrown:

Would it be possible to fix the Swagger so the SDK can return successful when deleted?

Thanks!

Author:	tombuildsstuff
Assignees:	akumardu
Labels:	IotHub, Service Attention
Milestone:	-