mem leak fix #3794
Merged
mem leak fix #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gearama
requested review from
RickWinter,
ahsonkhan,
antkmsft,
vhvb1989 and
LarryOsterman
as code owners
LarryOsterman
approved these changes
Jul 5, 2022
vhvb1989
approved these changes
Jul 5, 2022
vhvb1989
approved these changes
Jul 5, 2022
RickWinter
reviewed
Jul 6, 2022
LarryOsterman
requested changes
Jul 8, 2022
LarryOsterman
approved these changes
Jul 8, 2022
azure-sdk
added a commit
to azure-sdk/vcpkg
that referenced
this pull request
Aug 4, 2022
## 1.7.1 (2022-08-04) ### Bugs Fixed - [[microsoft#3794]](Azure/azure-sdk-for-cpp#3794) Fix memory leak in `CurlTransport`. - [[microsoft#3692]](Azure/azure-sdk-for-cpp#3692) Interrupted poll calls cause spurious HTTP request failures. (A community contribution, courtesy of _[johnwheffner](https://github.com/johnwheffner)_) ### Acknowledgments Thank you to our developer community members who helped to make Azure Core better with their contributions to this release: - John Heffner _([GitHub](https://github.com/johnwheffner))_
sthagen
pushed a commit
to sthagen/microsoft-vcpkg
that referenced
this pull request
Aug 4, 2022
## 1.7.1 (2022-08-04) ### Bugs Fixed - [[microsoft#3794]](Azure/azure-sdk-for-cpp#3794) Fix memory leak in `CurlTransport`. - [[microsoft#3692]](Azure/azure-sdk-for-cpp#3692) Interrupted poll calls cause spurious HTTP request failures. (A community contribution, courtesy of _[johnwheffner](https://github.com/johnwheffner)_) ### Acknowledgments Thank you to our developer community members who helped to make Azure Core better with their contributions to this release: - John Heffner _([GitHub](https://github.com/johnwheffner))_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mem leak due to raw pointer used for curl requests. The pointer if leaked when throwing from the subsequent checks.
Since we were wraping it in a unique pointer of CurlConnection whom's destructor takes care of cleaning up the curl pointer, right before returning, make sure the unique pointer gets created before the first potential throw.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.