Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using connectionPolicy.requestTimeout in RntbdTransportClient.builder #25090

Closed
xinlian12 opened this issue Oct 28, 2021 · 1 comment
Closed

Using connectionPolicy.requestTimeout in RntbdTransportClient.builder #25090

xinlian12 opened this issue Oct 28, 2021 · 1 comment
Assignees
@xinlian12
Projects
Cosmos DB SDK team

Comments

@xinlian12
Copy link
Member

Currently, requestTimeout is not publicly configurable. So we allow customer to override by using system property.

DefaultOptions -> System property or ConnectionPolicy.Default
requestTimeout -> DefaultOptions.requestTimeout

In the future, when we add the public API for request timeout, we should wire up correctly from connectionPolicy:
requestTimeout -> connectionPolicy.requestTimeout
@xinlian12 xinlian12 self-assigned this Oct 28, 2021
@xinlian12 xinlian12 added this to To do in Cosmos DB SDK team via automation Oct 28, 2021
@xinlian12
Copy link
Member Author

Not related any more.
Added networkRequestTimeout public API to be used in Rntbd.

Cosmos DB SDK team automation moved this from To do to Done Nov 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xinlian12 xinlian12

Labels
None yet
Projects
Cosmos DB SDK team
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xinlian12