Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Maps] - Onboarding for Search, Route, Render SDKs. #29580

Merged
merged 15 commits into from Aug 25, 2022
Merged

[Azure Maps] - Onboarding for Search, Route, Render SDKs. #29580

merged 15 commits into from Aug 25, 2022

Conversation

khmic5
Copy link
Contributor

@khmic5 khmic5 commented Jun 21, 2022

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@khmic5
Copy link
Contributor Author

khmic5 commented Jun 21, 2022

/azp run prepare-pipelines

@khmic5
Copy link
Contributor Author

khmic5 commented Jun 21, 2022

/azp run java - azure-maps-route - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@khmic5
Copy link
Contributor Author

khmic5 commented Jun 21, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 21, 2022 •
edited

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-maps-search
azure-maps-route
azure-maps-render
azure-maps-search
azure-maps-render
azure-maps-route

@khmic5 khmic5 changed the title added search route render [Azure Maps] - Onboarding for Search, Route, Render SDKs. Jun 21, 2022
@khmic5
Copy link
Contributor Author

khmic5 commented Jun 21, 2022

/azp run java - azure-maps-route - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khmic5 khmic5 marked this pull request as ready for review June 22, 2022 05:52
@khmic5 khmic5 marked this pull request as draft June 27, 2022 11:32
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@khmic5 khmic5 force-pushed the maps/onboarding/search-route-render branch from 974693f to 7db1a2c Compare June 29, 2022 05:03
@khmic5
Copy link
Contributor Author

khmic5 commented Jun 29, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khmic5
Copy link
Contributor Author

khmic5 commented Jul 2, 2022

/azp run prepare-pipelines

@vcolin7 vcolin7 reopened this Aug 18, 2022
@vcolin7
Copy link
Member

vcolin7 commented Aug 18, 2022

/check-enforcer evaulate

srnagar
srnagar reviewed Aug 22, 2022
View reviewed changes
eng/versioning/version_client.txt Outdated Show resolved Hide resolved
sdk/maps/README.md Outdated Show resolved Hide resolved
sdk/maps/README.md Outdated Show resolved Hide resolved
sdk/maps/README.md Outdated Show resolved Hide resolved
sdk/maps/azure-maps-render/CHANGELOG.md Show resolved Hide resolved
sdk/maps/azure-maps-render/src/main/java/com/azure/maps/render/models/MapTileSize.java Outdated
public static final MapTileSize SIZE256 = fromString("256");

/** Static value 512 for MapTileSize. */
public static final MapTileSize SIZE512 = fromString("512");
Copy link
Member

@srnagar srnagar Aug 22, 2022 •
edited by khmic5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un-resolving as this is not resolved yet.

khmic5: resolved!

sdk/maps/azure-maps-render/src/main/java/com/azure/maps/render/models/MapTileset.java Outdated Show resolved Hide resolved
sdk/maps/azure-maps-render/src/main/java/com/azure/maps/render/models/MapTileset.java Outdated Show resolved Hide resolved
...ps/azure-maps-render/src/main/java/com/azure/maps/render/models/RegionCopyrightsCountry.java Outdated Show resolved Hide resolved
sdk/maps/azure-maps-route/pom.xml Outdated Show resolved Hide resolved
@khmic5
Copy link
Contributor Author

khmic5 commented Aug 23, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khmic5
Copy link
Contributor Author

khmic5 commented Aug 23, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khmic5
Copy link
Contributor Author

khmic5 commented Aug 23, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khmic5
Copy link
Contributor Author

khmic5 commented Aug 25, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

srnagar
srnagar approved these changes Aug 25, 2022
View reviewed changes
sdk/maps/azure-maps-route/README.md Outdated Show resolved Hide resolved
@khmic5
Copy link
Contributor Author

khmic5 commented Aug 25, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@srnagar
Copy link
Member

srnagar commented Aug 25, 2022

/check-enforcer evaluate

@khmic5 khmic5 enabled auto-merge (squash) August 25, 2022 19:32
@weshaggard
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khmic5 khmic5 merged commit 76cc578 into Azure:main Aug 25, 2022
Harshan01 pushed a commit to Harshan01/azure-sdk-for-java that referenced this pull request Aug 30, 2022
@khmic5
[Azure Maps] - Onboarding for Search, Route, Render SDKs. (Azure#29580)
2305db5 
* Adding Azure Maps Search Route Render
vcolin7 pushed a commit to vcolin7/azure-sdk-for-java that referenced this pull request Sep 9, 2022
@khmic5 @vcolin7
[Azure Maps] - Onboarding for Search, Route, Render SDKs. (Azure#29580)
c57aa76 
* Adding Azure Maps Search Route Render
@JimSuplizio JimSuplizio mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubiety dubiety dubiety approved these changes

@srnagar srnagar srnagar approved these changes

@hallipr hallipr Awaiting requested review from hallipr

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@khmic5 @azure-sdk @vcolin7 @srnagar @weshaggard @dubiety