Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUERY] Why is azure-spring-cloud-starter-appconfiguration-config not part of spring-cloud-azure-dependencies 4.3.0? #29899

Closed
1 task done
ac-rdn opened this issue Jul 11, 2022 · 12 comments
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-app-configuration Spring app configuration related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@ac-rdn
Copy link

ac-rdn commented Jul 11, 2022

Query/Question
After upgrading spring-cloud-azure-dependencies to the latest version 4.3.0, I have to manually add dependency azure-spring-cloud-starter-appconfiguration-config (version 2.8.0) in order to load the configuration for my Spring Boot application from Azure Cloud Config Store.
Part of the Spring Cloud Azure 4.0 design changes was/is a simplified dependency management using a single spring-cloud-azure-dependencies BOM. And that's awesome! 👍 That's why I wonder if this is intended behavior? Because now I still have to maintain 2 versions: one for the BOM & one for the starter appconfiguration config.

Why is this not a Bug or a feature Request?
If the dependency is added, it works correctly.

Setup (please complete the following information if applicable):

  • IDE: IntelliJ
  • Library/Libraries: com.azure.spring:spring-cloud-azure-dependencies:4.3.0, com.azure.spring:azure-spring-cloud-starter-appconfiguration-config:2.8.0

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Setup information Added
@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 11, 2022
@mrm9084
Copy link
Member

mrm9084 commented Jul 11, 2022

@ac-rdn, the App Configuration libraries haven't moved over to the knew design yet as there are some conflicts with missing features. The Feature Management library has a beta to move it up to the 4.0 design. And the other library is currently being worked on to be updated.

@stliu, can we get the App Config libraries into the BOM before the 4.0 update is made to them. There is no conflict with dependencies.

@Netyyyy Netyyyy added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues azure-spring-app-configuration Spring app configuration related issues. labels Jul 12, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 12, 2022
@Netyyyy Netyyyy added this to the 2022-08 milestone Jul 12, 2022
@saragluna
Copy link
Member

@mrm9084 there were two main reasons for not adding App Config libraries to the Spring Cloud Cloud Azure BOM:

  • The App Config Spring libraries haven't been moved to the 4.0 design yet
  • The release cadence may differ between App Config ones and 4.0 libs. If there's any change to one module of the 4.0 libs, we will release a new version for all of them.

So we'd better add App Config libs to the BOM after it's been moved to 4.0.

@moarychan moarychan modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ac-rdn
Copy link
Author

ac-rdn commented Aug 19, 2022

Which additional information do I need to provide to help address this issue (and prevent it from being automatically closed)

@ghost ghost added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-author-feedback More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. labels Aug 19, 2022
@mrm9084
Copy link
Member

mrm9084 commented Aug 22, 2022

That might have even a side effect of me @ing you. We need no additional information at this moment.

@yiliuTo yiliuTo added the needs-author-feedback More information is needed from author to address the issue. label Nov 4, 2022
@stliu stliu modified the milestones: 2022-09, Backlog Nov 7, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Nov 14, 2022
@ghost
Copy link

ghost commented Nov 14, 2022

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ac-rdn
Copy link
Author

ac-rdn commented Nov 14, 2022

Which additional information do I need to provide to help address this issue (and prevent it from being automatically closed)?

@ghost ghost removed needs-author-feedback More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. labels Nov 14, 2022
@mrm9084
Copy link
Member

mrm9084 commented Nov 14, 2022

@ac-rdn, not sure why that popped up.

Status on this. The reason it isn't in the dependency list at the moment is that it doesn't have a 4.0 version. Currently there is a PR up to make one, but it doesn't seem like it will be merged/released any time soon. The current App Config version works fine with the other libraries, it just doesn't support the global properties for configuration.

@yanivnahoum
Copy link

@mrm9084 Now I see that spring-cloud-azure-starter-appconfiguration-config v4.7.0 is managed correctly by spring-cloud-azure-dependencies v4.7.0, but is still missing from v5.1.0 bom, even though the change log says it's been added, AND the starter itself has a v5.1.0.

@saragluna
Copy link
Member

@yanivnahoum, we apologize for the mistake of leaving out the starter from the bom. We will include it in the upcoming release, which could be either 5.1.1 or 5.2.0.

@yanivnahoum
Copy link

Thanks @saragluna !

@saragluna
Copy link
Member

App configuration-related libs have been added to Spring Cloud Azure BOM for the latest version of both 4.x and 5.x. Closing this issue now.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-app-configuration Spring app configuration related issues. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Archived in project
Development

No branches or pull requests

8 participants