Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PPE live tests for Identity SDK #32389

Merged
merged 28 commits into from Dec 8, 2022
Merged

Support PPE live tests for Identity SDK #32389

merged 28 commits into from Dec 8, 2022

Conversation

ostoliarova-msft
Copy link
Member

@ostoliarova-msft ostoliarova-msft commented Dec 1, 2022 •
edited

Description

This PR addresses the story User Story 2766257: [SDK] Run Identity live tests in PPE. As Dogfood environment is quite unstable, and tests fail quite often due to failing deployment of test resources, we are adding tests in PPE to have more stable test runs.
The following steps were made:

  • created a secret value in the KeyVault which contains subscription configs for PPE resources.
  • added new variables which point to the newly created secrets to the variable group of the live test pipeline
  • added config for PPE tests
  • run live test pipelines: result here

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Dec 1, 2022
@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-idenityty - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-idenitity - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft
Copy link
Member Author

/azp run java - azure-communication-identity - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ostoliarova-msft ostoliarova-msft changed the title run live tests in ppe Support PPE live tests for Identity SDK Dec 7, 2022
@ostoliarova-msft ostoliarova-msft marked this pull request as ready for review December 7, 2022 11:52
@ostoliarova-msft ostoliarova-msft marked this pull request as draft December 7, 2022 11:52
@ostoliarova-msft ostoliarova-msft marked this pull request as ready for review December 7, 2022 11:54
@ostoliarova-msft ostoliarova-msft merged commit 52b391a into Azure:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@petrsvihlik petrsvihlik petrsvihlik approved these changes

@maximrytych-ms maximrytych-ms maximrytych-ms approved these changes

@hallipr hallipr Awaiting requested review from hallipr

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

Assignees
No one assigned
Labels
Communication - Identity Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ostoliarova-msft @azure-sdk @benbp @petrsvihlik @maximrytych-ms @olena-stoliarova