Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, regenerate for monitor on updated package-composite-v1 #32767

Merged

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jan 4, 2023

fix Azure/autorest.java#1912

manual change fcc24c7 (the change to client name is reverted as a few new swagger is excluded from package-composite-v1)

clean-up due to codegen improvement 8ce753c

live tests pass.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 4, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-monitor

@weidongxu-microsoft weidongxu-microsoft changed the title mgmt, regen monitor mgmt, regenerate for monitor on updated package-composite-v1 Jan 5, 2023
@weidongxu-microsoft weidongxu-microsoft added the Mgmt This issue is related to a management-plane library. label Jan 5, 2023
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review January 5, 2023 02:50
@weidongxu-microsoft weidongxu-microsoft merged commit 0cbeeef into Azure:main Jan 5, 2023
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_regen-monitor branch January 5, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sample Issue]
3 participants