Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track 1 performance libraries shouldn't depend on perf-test-core #39227

Open
alzimmermsft opened this issue Mar 14, 2024 · 0 comments
Open

Track 1 performance libraries shouldn't depend on perf-test-core #39227

alzimmermsft opened this issue Mar 14, 2024 · 0 comments
Assignees
Labels
common common module used by all azure SDKs (e.g. client, Mgmt) pillar-performance The issue is related to performance, one of our core engineering pillars. Track 1

Comments

@alzimmermsft
Copy link
Member

The few Track 1 performance libraries in the repository shouldn't depend on perf-test-core as it uses Track 2 dependencies and Track 1 and Track 2 libraries shouldn't intermingle dependencies. A separate common performance testing library should be added for the Track 1 libraries that doesn't have any dependencies on Track 2 libraries.

The current setup breaks expectation of dependencies and causes issues in CI which can result in CI jobs running too many libraries or result in them failing due to their inability to compile Track 1 libraries.

@alzimmermsft alzimmermsft added common common module used by all azure SDKs (e.g. client, Mgmt) pillar-performance The issue is related to performance, one of our core engineering pillars. labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common common module used by all azure SDKs (e.g. client, Mgmt) pillar-performance The issue is related to performance, one of our core engineering pillars. Track 1
Projects
Status: No status
Development

No branches or pull requests

3 participants