Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove slf4j dependency in clientcore #39606

Closed
JonathanGiles opened this issue Apr 8, 2024 · 0 comments
Closed

Remove slf4j dependency in clientcore #39606

JonathanGiles opened this issue Apr 8, 2024 · 0 comments
Assignees
@vcolin7
Labels
Client This issue points to a problem in the data-plane of the library. clientcore

Comments

@JonathanGiles
Copy link
Member

JonathanGiles commented Apr 8, 2024 •
edited

Current plan:

  • Remove slf4j dependency from generic core.
  • Update ClientLogger to reflectively look for slf4j on the classpath, and if it is present, reflectively use that API. If it is not present, use the existing code to print to console.

We can then follow-up, potentially, to remove it from azure-core as well.
@github-actions github-actions bot added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 8, 2024
@JonathanGiles JonathanGiles changed the title Consider removing slf4j dependency Remove slf4j dependency in clientcore Apr 8, 2024
@vcolin7 vcolin7 mentioned this issue Apr 13, 2024
Merged
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. clientcore labels Apr 15, 2024
@github-actions github-actions bot removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 15, 2024
@vcolin7 vcolin7 mentioned this issue Apr 17, 2024
Open
@vcolin7 vcolin7 mentioned this issue May 1, 2024
Merged
@vcolin7 vcolin7 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vcolin7 vcolin7

Labels
Client This issue points to a problem in the data-plane of the library. clientcore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonathanGiles @vcolin7 @alzimmermsft