Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a token via VisualStudioCodeCredential using v0.10.0 of the Azure Account Extension results in an error #20500

Closed
6 tasks
wwlorey opened this issue Feb 23, 2022 · 4 comments
Assignees
Labels
Azure.Identity bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization.
Milestone

Comments

@wwlorey
Copy link

wwlorey commented Feb 23, 2022

  • Package Name: @azure/identity
  • Package Version: latest
  • Operating system: Windows
  • nodejs
    • version: 17.5.0
  • browser
    • name/version: N/A
  • typescript
    • version: 4.0.2
  • Is the bug related to documentation in

Describe the bug
In version 0.10.0, the Azure Account Extension for VS Code started consuming the VS Code secrets API instead of using keytar directly for caching tokens. It looks like the identity package relies on the old way the extension was using to store these tokens as demonstrated by the following error. This is sometimes thrown when users attempt to get tokens using VisualStudioCodeCredential:
image

To Reproduce
Please see the repro steps in microsoft/vscode-azure-account#443 (comment) and more info in microsoft/vscode-azure-account#443 (comment).

Expected behavior
The identity package succeeds in reading tokens cached by the Azure Account Extension.

More info
A more robust way of talking to the Azure Account Extension is through the extension API if that's an option for this package.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Feb 23, 2022
@azure-sdk azure-sdk added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage This issue needs the team to triage. labels Feb 23, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Feb 23, 2022
@ramya-rao-a ramya-rao-a added this to the [2022] March milestone Feb 23, 2022
@ramya-rao-a ramya-rao-a added bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 23, 2022
@KarishmaGhiya
Copy link
Contributor

Thank you for filing the bug. The change in the cache name to store token has affected identity libraries in all languages. We are working on a solution. We will have an update for you before next Wednesday

@KarishmaGhiya KarishmaGhiya removed the needs-team-triage This issue needs the team to triage. label Feb 24, 2022
@KarishmaGhiya
Copy link
Contributor

@wwlorey I have a question for the VS Code team here - microsoft/vscode-azure-account#443 (comment)

@StephenWeatherford
Copy link

@wwlorey Does this affect all extensions that use azure account, or are we (the Bicep extension with some new code) affected by this based on us doing something differently? Don't fully understand why you don't publish a reverted version to fix this until you get a real fix, especially if it's not just us. Thx.

cc @ucheNkadiCode, @bhsubra

@KarishmaGhiya KarishmaGhiya added this to the 2022-09 milestone Aug 1, 2022
@KarishmaGhiya KarishmaGhiya modified the milestones: 2022-09, 2022-12 Aug 9, 2022
@billwert
Copy link
Contributor

This issue has been mitigated for Copper and will be resolved more fully in Zinc. #22904

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
Development

No branches or pull requests

8 participants