[Storage] ConnectionString requires EndpointSuffix

[mikeharder]

I am trying to use the Blob connection string sample:

https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/storage/storage-blob/samples/v12/typescript/src/connectionStringAuth.ts

With the first example shown in the Storage Connection String docs:

DefaultEndpointsProtocol=https;AccountName=myAccountName;AccountKey=myAccountKey

https://docs.microsoft.com/en-us/azure/storage/common/storage-configure-connection-string#configure-a-connection-string-for-an-azure-storage-account

It fails with this error:

Error: Invalid EndpointSuffix in the provided Connection String

It works if I add the default EndpointSuffix:

DefaultEndpointsProtocol=https;AccountName=myAccountName;AccountKey=myAccountKey;EndpointSuffix=core.windows.net

But I do not believe the EndpointSuffix is required in most other languages.

[xirzec]

/cc @jeremymeng any thoughts on this one?

[jeremymeng]

Looks that instead of throwing error, we could use a default value of "core.windows.net"?

azure-sdk-for-js/sdk/storage/storage-blob/src/utils/utils.common.ts

Lines 208 to 212 in f5de119

	endpointSuffix = getValueInConnString(connectionString, "EndpointSuffix");
	if (!endpointSuffix) {
	throw new Error("Invalid EndpointSuffix in the provided Connection String");
	}
	blobEndpoint = `${defaultEndpointsProtocol}://${accountName}.blob.${endpointSuffix}`;

[EmmaZhu]

I agree. We should have a default endpoint value. I'll fix it.

[JoostLambregts]

I would like to note that this is also an issue in the data-tables SDK, See line 46 in https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/tables/data-tables/src/utils/accountConnectionString.ts

    if (!endpointSuffix) {
      throw new Error("Invalid EndpointSuffix in the provided Connection String");
    }

[github-actions]

Hi @mikeharder, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.