[load-testing] upgrade dependency @azure/abort-controller to ^2.1.2 #29806
+78
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeremymeng
commented
May 24, 2024
•
jeremymeng
commented
- fix compilation errors.
- fix v1-beta samples targeting version
- update tests
- fix compilation errors. - fix v1-beta samples targeting version - update tests
github-actions
bot
added
the
Mgmt
jeremymeng
commented
May 24, 2024
| @@ -19,7 +18,7 @@ describe("Test Creation", () => { | |||
|
|
|||
| beforeEach(async function (this: Context) { | |||
| recorder = await createRecorder(this); | |||
| if (!isNode || isPlaybackMode()) { | |||
| if (!isNodeLike || isPlaybackMode()) { | |||
There was a problem hiding this comment.
not sure why playback testing is skipped.
|
API change check API changes are not detected in this pull request. |
|
@kazrael2119 please help review. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.