[dependency-test] support packages that moved to vitest #29898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by writing a copy of vitest config file to the test/public project and update related commands to run vitest. This PR addresses NodeJs only.
jeremymeng
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
|
/azp run js - template - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeremymeng
commented
Jun 4, 2024
|
This looks good to me. Have we run a pipeline with minmax test to ensure the fix will work? |
KarishmaGhiya
approved these changes
Jun 12, 2024
Yes, |
deyaaeldeen
reviewed
Jul 17, 2024
| if (packageJsonContents.name.startsWith("@azure/")) { | ||
| testPackageJson.name = packageJsonContents.name.replace("@azure/", "azure-") + "-test"; | ||
| } else if (packageJsonContents.name.startsWith("@azure-rest/")) { | ||
| testPackageJson.name = | ||
| packageJsonContents.name.replace("@azure-rest/", "azure-rest-") + "-test"; | ||
| } | ||
| await usePackageTestTimeout(testPackageJson, packageJsonContents); | ||
| testPackageJson.type = packageJsonContents.type; | ||
| if (packageJsonContents.scripts["integration-test:node"].includes("vitest")) { | ||
| testPackageJson.scripts["integration-test:node"] = "dev-tool run test:vitest -- -c vitest.dependency-test.config.ts"; |
There was a problem hiding this comment.
why not running with the library's original vitest config? this is causing issues for event hubs tests
There was a problem hiding this comment.
For dependency testing we essentially create a new package under test/public. We could point to the original vitest config if the paths etc. still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by writing a copy of vitest config file to the test/public project and update
related commands to run vitest.
This PR addresses NodeJs only.
Related issue: #29867