Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity: Implement Interactive Authentication Support for Node.js applications #4774

Closed
funkydev opened this issue Aug 15, 2019 · 8 comments
Labels
AAD Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@funkydev
Copy link

funkydev commented Aug 15, 2019

Gets the token through an interactive process that prompts the user for credentials through a browser like in @azure/ms-rest-nodeauth library.

It is necessary for authenticating user/password with configured 2FA in the Azure portal.

Notice that node.js doesn't support opening browser window, so library needs to return the url where user can pass the credentials (like in @azure/ms-rest-nodeauth).

@loarabia loarabia added AAD Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 16, 2019
@loarabia
Copy link

Tagging for review to see if this is something that could be in the common libraries for the SDKs.

@funkydev
Copy link
Author

In my opinion that should be implemented as soon as possible. Your team says that @azure/ms-rest-nodeauth will be deprecated soon and @azure/identity doesn't support all functionalities.

Interactive authentication is the only one method, which you can authenticate AAD user with 2FA configured.

@daviwil
Copy link
Contributor

daviwil commented Aug 22, 2019

Hi Kacper, let me clarify what I was telling the PR author in Azure/ms-rest-nodeauth#75 (comment): we aren't deprecating ms-rest-nodeauth anytime soon, I was merely letting the author know that we are focusing our attention on @azure/identity at the moment.

Regardless of what I said there, we are taking steps to ensure that ms-rest-nodeauth remains compatible with the new SDK libraries for the forseeable future. You shouldn't worry about ms-rest-nodeauth going away before @azure/identity has the appropriate credential coverage.

Let me know if I can provide any further clarification!

@funkydev
Copy link
Author

That's clear now. Thank you @daviwil.

I wanted that information to know, how should I have to plan my work. I'm working on a project which needs Interactive Authentication support and now I know what is going on.

I'm waiting for any updates 👀

@sophiajt
Copy link
Contributor

@funkydev - We've added a few additional ways to authenticate to the Identity library.

One possible fit for what you're looking for is device code credential, which let's you interactively get a code on your device that you can use to log in with. Is this similar to what you're looking for, by chance?

@joshfree joshfree added this to the Backlog milestone Oct 2, 2019
@daviwil daviwil added the blocking-release Blocks release label Oct 14, 2019
@ramya-rao-a ramya-rao-a removed the blocking-release Blocks release label Oct 16, 2019
@funkydev
Copy link
Author

@jonathandturner Right, Device Code Credentials are what I've looked for. It solves the issue, thank you! ✋

@daviwil
Copy link
Contributor

daviwil commented Nov 8, 2019

We are still planning to implement InteractiveBrowserCredential for Node.js but didn't have time to include it in the 1.0 GA release. We hope to get it implemented in a future feature update in early 2020.

@xirzec xirzec modified the milestones: [2020] February, Backlog Feb 11, 2020
@ramya-rao-a ramya-rao-a added the feature-request This issue requires a new behavior in the product in order be resolved. label Jul 16, 2020
@sophiajt
Copy link
Contributor

sophiajt commented Sep 9, 2020

Closing as this is now available as part of https://www.npmjs.com/package/@azure/identity/v/1.2.0-beta.1. You can use the InteractiveBrowserCredential in node, and doing so will pop up the user's default web browser, start a web server, and redirect the token from the browser back to your application.

Please let us know how this works for you.

@sophiajt sophiajt closed this as completed Sep 9, 2020
@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AAD Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

7 participants