Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Record and Playback] Optimizations on new recordings #4879

Closed
sadasant opened this issue Aug 23, 2019 · 1 comment
Closed

[Record and Playback] Optimizations on new recordings #4879

sadasant opened this issue Aug 23, 2019 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder

Comments

@sadasant
Copy link
Contributor

sadasant commented Aug 23, 2019

When small changes happen in the tests, they generate snapshots that might not be necessary to add as changes to the repository, since they only consist on minor variations that are irrelevant to the tests, such as a date change or the value of a temporary token. See the screenshot below:

SharedScreenshot

We could make the recorder automatically remove these values, and thus making that future test changes only show the relevant changes in the recordings and not all of these minor & irrelevant differences.

Recommended way to approach this:

@sadasant sadasant self-assigned this Aug 23, 2019
@kaerm kaerm added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Aug 26, 2019
@kurtzeborn kurtzeborn removed the EngSys This issue is impacting the engineering system. label Aug 27, 2019
@ramya-rao-a ramya-rao-a added the test-utils-recorder Label for the issues related to the common recorder label Jan 29, 2020
@xirzec xirzec added this to the Backlog milestone Jan 29, 2020
Copy link

Hi @sadasant, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Development

No branches or pull requests

5 participants