Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common Recorder] Update the KeyVault packages to use the latest API #5157

Closed
sadasant opened this issue Sep 16, 2019 · 3 comments
Closed

[Common Recorder] Update the KeyVault packages to use the latest API #5157

sadasant opened this issue Sep 16, 2019 · 3 comments
Assignees

Comments

@sadasant
Copy link
Contributor

Follow the list here: #4229

@ramya-rao-a
Copy link
Contributor

@sadasant Can you clarify which API are we referring to here when we say "Update the KeyVault packages to use the latest API"?

Also, when you say "Follow the list here: #4229", do you mean the entire list there or just the below?
image

cc @jonathandturner

@sadasant
Copy link
Contributor Author

sadasant commented Nov 22, 2019

It's all of it. The keyvault packages have a recorder that remains from the older code we had. It also has references to methods to obtain unique strings and delays. The recorder now has some of this, but I want to make sure that it addresses what we address in KeyVault. I haven't wanted to do that preemptively because I think there's not a perfect overlap. I will clean this up, for sure.

@ramya-rao-a
Copy link
Contributor

Closing in favor of #6300

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants