-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-http] timeout isn't working on the browser #5747
Comments
Why didn't we such issues with storage-packages, we don't have tests in storage that covers this? |
@sadasant, can you provide me with a branch that repros this? |
For reference - https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/keyvault-certificates/test/CRUD.test.ts#L79-L97 from @sadasant So, the test is being currently run only in node and live, rest of the combinations fail.
|
Here's something interesting. If we set the following it.only("can create a key with requestOptions timeout", async function() {
}
it.only("can create a RSA key with requestOptions timeout", async function() {
}
it.only("can create an EC key with requestOptions timeout", async function() {
} However, if after doing that one does it.only("can create a key while giving a manual type", async function() {
} Then that one will pass, and the others with timeout will crash. |
I closed this by mistake. |
Closing with #7159 Logging separate issues for node and browser playback. |
Describe the bug
The timeout option of RequestOptionsBase, if sent to an http request over the browser, is not properly working, as in: the timeout never happens, the request goes through as if this option wasn't present.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The requests should trigger the timeout.
The text was updated successfully, but these errors were encountered: