Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] In flight messages get ignored in batch receiver if timer runs out #6270

Closed
ramya-rao-a opened this issue Nov 20, 2019 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 20, 2019

This issue is a follow up from #6004 (review)

When receiveMessages() is called we resolve the returned promise in the below scenarios

  • required number of messages are collected
  • or the wait time that was provided has elapsed
  • or more than 1 sec has passed since last message was received

In the second and third cases, it can be possible that rhea received a message, fired the message event which then got ignored because we removed the listeners in preparation to resolve the promise. Such in flight messages get ignored, which is not a big deal in peek lock mode, but results in data loss in case of receive and delete mode.

This issue is to first investigate if the above is possible and then to explore solutions.

cc @ramya0820

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Nov 20, 2019
@HarshaNalluru HarshaNalluru added this to the [2020] June milestone Apr 9, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] June, Backlog May 5, 2020
@richardpark-msft
Copy link
Member

Moving to August - we should definitely get to this investigation before release.

@ramya-rao-a ramya-rao-a modified the milestones: [2020] August, Backlog Aug 5, 2020
@richardpark-msft
Copy link
Member

At this point we've done a lot of work in this area and cases 2 and 3 above have been covered (and had fixes). I feel comfortable closing this.

Fixes:

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

4 participants