Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] Follow script guidelines #6555

Closed
sadasant opened this issue Dec 13, 2019 · 2 comments
Closed

[Recorder] Follow script guidelines #6555

sadasant opened this issue Dec 13, 2019 · 2 comments
Labels
test-utils-recorder Label for the issues related to the common recorder

Comments

@sadasant
Copy link
Contributor

We need to make sure to follow the guidelines on the required package scripts: https://github.com/Azure/azure-sdk-for-js/blob/master/CONTRIBUTING.md#other-npm-scripts

More information here: #6430 (comment)
@sadasant sadasant added the test-utils-recorder Label for the issues related to the common recorder label Dec 13, 2019
@HarshaNalluru HarshaNalluru mentioned this issue Dec 13, 2019
Closed
62 tasks
@sadasant sadasant mentioned this issue Dec 13, 2019
Merged
@ramya-rao-a
Copy link
Contributor

The guidance in #6430 (comment) that all projects MUST have the npm scripts listed in https://github.com/Azure/azure-sdk-for-js/blob/master/CONTRIBUTING.md#other-npm-scripts is to ensure that all the projects are built and tested in various pipelines correctly.

The recorder package is an internal utility and as far as I know does not have tests that need to be run as part of CI. Therefore, I believe this issue is not needed.

@sadasant
Copy link
Contributor Author

I'll close this then! Thank you.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sadasant @ramya-rao-a